Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Ability load models saved using versions before 1.7 #1207

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Fix: Ability load models saved using versions before 1.7 #1207

merged 1 commit into from
Nov 19, 2024

Conversation

tylernisonoff
Copy link
Contributor

Fixes #1206

Uses the following defaults if they are not found in config_dict

defaults = {
    "id_col": "unique_id", 
    "time_col": "ds",
    "target_col": "y",
}

In 1.6.4, local_scaler_type and scalers_ were added to the dataset, so we check to see if those are set on the dataset, and use those as defaults if found. otherwise, we default to None

@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@CLAassistant
Copy link

CLAassistant commented Nov 18, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@tylernisonoff tylernisonoff mentioned this pull request Nov 18, 2024
Closed
@tylernisonoff tylernisonoff changed the title Fix: Cannot load models saved using versions before 1.7 Fix: Ability load models saved using versions before 1.7 Nov 18, 2024
jmoralez
jmoralez approved these changes Nov 19, 2024
View reviewed changes
Copy link
Member

@jmoralez jmoralez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jmoralez jmoralez added the fix label Nov 19, 2024
@jmoralez jmoralez merged commit 642ced4 into Nixtla:main Nov 19, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmoralez jmoralez jmoralez approved these changes

Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Core] Cannot load models saved using versions before 1.7
3 participants
@tylernisonoff @CLAassistant @jmoralez